[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #26537 [Applications/Tor Browser]: Do not build the NSIS uninstaller for Firefox during `mach build stage-package`
#26537: Do not build the NSIS uninstaller for Firefox during `mach build stage-
package`
------------------------------------------+----------------------
Reporter: sukhbir | Owner: tbb-team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Keywords: ff60-esr
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
------------------------------------------+----------------------
Bug #26319 addressed the issue not packaging the Firefox DMG or EXE during
the `mach package` step by using `mach build stage-package`. However, we
still have an additional patch which fixes the error where the build fails
trying to find the NSIS file for creating the uninstaller:
{{{
31:23.55 update.locale
31:25.74 cp: cannot stat 'instgen/helper.exe': No such file or directory
31:25.74 /var/tmp/build/firefox-
a0efd2fcd6e9/toolkit/mozapps/installer/windows/nsis/makensis.mk:99: recipe
for target 'uninstaller' failed
31:25.74 make[5]: *** [uninstaller] Error 1
}}}
See the patch in `8d1c4c396034b2a` (`projects/firefox/nsis-
uninstall.patch`) which prevents the uninstaller from being built.
We should find a proper way to fix this so that we don't lose track of it.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26537>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs