[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26541 [Core Tor/Tor]: Fix minor mistakes in the bandwidth-file dir-spec entry

#26541: Fix minor mistakes in the bandwidth-file dir-spec entry
---------------------------------+------------------------------------
 Reporter:  teor                 |          Owner:  juga
     Type:  defect               |         Status:  assigned
 Priority:  Medium               |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  tor-bwauth, torspec  |  Actual Points:
Parent ID:  #3723                |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------
Description changed by juga:

Old description:

> atagar pointed out the following errors in the bandwidth-file dir-spec
> entry:
>
> The bandwidth-file line appears:
> {{{
> [At most once for votes; does not occur in consensuses.]
> }}}
>
> He also suggested that we could change the name to bandwidth-file-headers
> or bandwidth-headers if we want. I don't mind what we call it, but it has
> to match #3723.
>
> I also noticed that the definition of Value is wrong, it should be:
> {{{
> Value ::= ArgumentCharValue+
> ArgumentCharValue ::= any printing ASCII character except NL and SP.
> }}}
>
> ~~We should also add the new file_created and latest_bandwidth header
> keywords from bandwidth-file-spec.~~
>
> Edit: file_created and latest_bandwidth were added in #26155 and it has
> been merged 3 now to master

New description:

 atagar pointed out the following errors in the bandwidth-file dir-spec
 entry:

 The bandwidth-file line appears:
 {{{
 [At most once for votes; does not occur in consensuses.]
 }}}

 He also suggested that we could change the name to bandwidth-file-headers
 or bandwidth-headers if we want. I don't mind what we call it, but it has
 to match #3723.

 I also noticed that the definition of Value is wrong, it should be:
 {{{
 Value ::= ArgumentCharValue+
 ArgumentCharValue ::= any printing ASCII character except NL and SP.
 }}}

 We should also add the new file_created and latest_bandwidth header
 keywords from bandwidth-file-spec.

 Edit: file_created and latest_bandwidth were added in #26155 and it has
 been merged 3 now to master
 Edit: previous line is about adding them to dir-spec

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26541#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs