Re: [tor-bugs] #26541 [Core Tor/Tor]: Fix minor mistakes in the bandwidth-file dir-spec entry

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#26541: Fix minor mistakes in the bandwidth-file dir-spec entry
---------------------------------+------------------------------------
 Reporter:  teor                 |          Owner:  juga
     Type:  defect               |         Status:  needs_revision
 Priority:  Medium               |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  tor-bwauth, torspec  |  Actual Points:
Parent ID:  #3723                |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------

Comment (by juga):

 Replying to [comment:7 teor]:
 > Replying to [ticket:26541 teor]:
 > > The bandwidth-file line appears:
 > > {{{
 > > [At most once for votes; does not occur in consensuses.]
 > > }}}
 >
 > The patch has slightly different words. Please use the standard text
 here, so people can search for it:
 > {{{
 > [At most once for votes; does not occur in consensuses.
 > }}}

 I looked quickly how this was expressed and found
 https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n2358, but i
 didn't see other parts where it is expressed exactly as you propose
 https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n1649.
 So yeah, i'll change it to express it like that.

 > > I also noticed that the definition of Value is wrong, it should be:
 > > {{{
 > > Value ::= ArgumentCharValue+
 > > ArgumentCharValue ::= any printing ASCII character except NL and SP.
 > > }}}
 >
 > The definition is missing ArgumentCharValue, which does not appear
 anywhere else in dir-spec.txt:
 > {{{
 > ArgumentCharValue ::= any printing ASCII character except NL and SP.
 > }}}

 In dir-spec, we have ArgumentChar defined in section 1.2, so i thought we
 could use that, as we re-use the term Keyword from there.
 Actually i don't know now why i created ArgumentCharValue in bandwidth-
 file-spec, i could have reused ArgumentChar there too (if i'm not mistaken
 now).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26541#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs