Re: [tor-bugs] #26541 [Core Tor/Tor]: Fix minor mistakes in the bandwidth-file dir-spec entry

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#26541: Fix minor mistakes in the bandwidth-file dir-spec entry
---------------------------------+------------------------------------
 Reporter:  teor                 |          Owner:  juga
     Type:  defect               |         Status:  needs_review
 Priority:  Medium               |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  tor-bwauth, torspec  |  Actual Points:
Parent ID:  #3723                |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:13 teor]:

 > > I used ArgumentChar, let me know if that's not correct.
 >
 > One more fix - it needs to be ArgumentCharValue.
 >
 > ArgumentChar includes space:
 > {{{
 > ArgumentChar ::= any printing ASCII character except NL.
 > }}}
 >
 > ArgumentCharValue doesn't:
 > {{{
 > ArgumentCharValue ::= any printing ASCII character except NL and SP.
 > }}}

 oh, right, that was the reason why we introduced ArgumentCharValue, thanks
 for the pointer.

 > (Those names are confusing, aren't they? Maybe we should change
 ArgumentCharValue to ValueChar? We can open a separate ticket for that fix
 if you want.)

 they are, just leaving that name for now

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26541#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs