[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24920 [Applications/Tor Browser]: TBA has tabs and private tabs, we only want private tabs

#24920: TBA has tabs and private tabs, we only want private tabs
----------------------------------------------+----------------------------
 Reporter:  sysrqb                            |          Owner:  tbb-team
     Type:  defect                            |         Status:
                                              |  needs_revision
 Priority:  Medium                            |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201906  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, TorBrowserTeam201906R => tbb-mobile,
     TorBrowserTeam201906


Comment:

 Two things I am unsure about:

 1) It's a bit sad to see the look of the browsing experience differ now
 from what we had before as it seems the private mode is differently styled
 (dark grey URL bar e.g.). This is not the case on desktop it seems? We get
 the same look regardless whether we have permanent private browsing mode
 on or off. I have not checked why that's the case, but I feel if possible
 then it is worth aligning the mobile and desktop experience here (and by
 that I mean that we'd ideally not make a visual difference indicating
 which mode we are on to not leak that information).

 2) I spent a bit time trying to figure out why you do
 {{{
 +    let isPrivate = (("isPrivate" in aParams) && aParams.isPrivate) ||
 Services.prefs.getBoolPref("browser.privatebrowsing.autostart")
 }}}
 Is that for defense-in-depth? Or is there an actual need for that?
 Ideally, I think the check for that pref (or, better: for whether we are
 in private browsing mode or not) should be done somewhere else if it is
 missing and not at this place (but that's a bit hard to say as I am not
 sure why it is needed), but it could get at least a comment explaining why
 it is there.

 I am leaving this ticket open for addressing 2) and moved along with the
 changes meanwhile to get 9.0a2 built. I cherry-picked them to `tor-
 browser-60.7.0esr-9.0-1` (commits
 6d81ef66c55d5b88f39ee6527f8218b2f2e15cd8,
 1666b0186346ab2769614d3b19bc2058fd6f13f0,
 1bce86ec5cfff504baf6e61b9d356ff74c62b297, and
 41b5dac4943dcf65582f2638fe6d1b5c80127c0a).

 Could you please based your commits next time on whatever the current HEAD
 of the current tor-browser dev branch points to? I had to debug first why
 my testbuild was failing and it turned out that the Torbutton submodule
 commit you had on your branch did not point to any of the Torbutton
 commits in the repository but to one on a branch in my public Torbutton
 repo. Thus, the build was failing as the submodule update failed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24920#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs