[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30578 [Core Tor/Tor]: The circuitpadding_circuitsetup_machine test: Re-enable, remove, re-document, or ___?
#30578: The circuitpadding_circuitsetup_machine test: Re-enable, remove, re-
document, or ___?
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: asn
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: circuitpadding, 041-should, | Actual Points:
hopefully-easy, wtf-pad |
Parent ID: | Points:
Reviewer: | Sponsor:
| Sponsor2
-------------------------------------------------+-------------------------
Changes (by asn):
* status: assigned => needs_review
Comment:
OK I tried another time to fix the test, but it seems to be a PITA. The
test is testing some old complicated padding machines, and it's not
accounting for some state transitions that are possible (in particular the
relay machine transitions from BURST to GAP and sometimes sends padding
really fast before the test accounts for it). Fixing it would require
either huge changes to the test, or changes to the machine.
IMO we should just remove the test since it's just doing in-depth testing
of these machines that are now obsolete and only used as test machines. As
part of my branch I moved these machines to the unittest file since they
were never used by anything other than the unittests anyway:
https://github.com/torproject/tor/pull/1086
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30578#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs