[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27503 [Applications/Tor Browser]: Disabling accessibility on Windows breaks screen readers

#27503: Disabling accessibility on Windows breaks screen readers
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:
  GeorgKoppen201903, tbb-8.5-must,               |
  TorBrowserTeam201906R                          |
Parent ID:                                       |         Points:
 Reviewer:  boklm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by pospeselr):

 * keywords:
     tbb-8.0-issues, tbb-regression, GeorgKoppen201903, tbb-8.5-must,
     TorBrowserTeam201905
     =>
     tbb-8.0-issues, tbb-regression, GeorgKoppen201903, tbb-8.5-must,
     TorBrowserTeam201906R


Comment:

 Ok for better reviewability, here is the widl changes that fix the various
 bugs, as well as a change to widl.c that mingw applies when building to
 handle mingw's default include directories.

 wine: https://github.com/pospeselr/wine/commits/bug_27503

 Once my current build finishes, I'll amend the tor-browser-build branch
 for mingw to remove the changes to VERSION and configure as they only
 update the version string to 4.9 from 3.20 but doesn't functionally alter
 any of the compiler output (apart from version strings)

 To generate the mingw-w64 patch in the bug_27503 tor-browser-build branch
 for yourself, you will need to first build wine (to generate the parser
 source from the yacc grammar file), then copy all of the *.c, *.h, *.l,
 and *.y files from the `wine/tools/widl` directory to
 `mingw-w64/mingw-w64-tools/widl/src` directory and do a `git diff`. This
 should generate the same 27503.patch file in `tor-browser-
 build/projects/mingw-w64`

 NOTE: To build widl, from the wine root do a `./configure --without-x
 --without-freetype` and the usual `make`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27503#comment:66>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs