[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

#29280: Use Chutney in Tor's CI
-------------------------------------------------+-------------------------
 Reporter:  cohosh                               |          Owner:  (none)
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  CI, PTs, 029-backport,               |  Actual Points:  1.5
  035-backport, 040-backport, network-team-      |
  roadmap-2019-Q1Q2, reviewer-was-               |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267                               |         Points:  1
 Reviewer:  teor                                 |        Sponsor:
                                                 |  Sponsor19
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * reviewer:   => teor


Comment:

 The CI and config look good.
 So do the merges.

 0.3.5 and later is going to conflict with #30591, let's try to merge this
 change, then rebase #30591. (#29280 is more complex than #30951, which is
 a simple patch on 0.3.5 and a clean merge forward.)

 I like that we are re-using "make test-network-all", there's no need to
 mess around with chutney networks vs tor versions.

 We're almost there!

 There's a few tweaks that we need to do for good diagnostics:
 * cat test_network_log on failure
 * show the python version in 0.2.9 and 0.3.5, like we do in 0.4.0 and
 later
   * if we cherry-pick c31346ffb4, the merges might be eaiser
   * but the comment about stem is wrong:
     * in 0.2.9, we don't run stem
     * in 0.3.5 and later, that line just shows the stem version, it
 doesn't actually run stem
 * show the chutney commit hash after we check it out

 (We've needed all this information to diagnose stem and test failures in
 the past, so let's put it in now.)

 There's one fix that I would do, but feel free to do whatever you think is
 easiest to maintain and read:
 * remove the redundant os: linux line (see my comment in the pull request)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29280#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs