[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30893 [Core Tor/Tor]: Refactor and improve test coverage in confparse.c

#30893: Refactor and improve test coverage in confparse.c
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_information
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  1
Parent ID:  #29211        |         Points:  1
 Reviewer:  catalyst      |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:1 nickm]:
 > See branch `ticket30893` with PR at
 https://github.com/torproject/tor/pull/1113 . It gets us to 100% coverage
 on `confparse.c`.

 Thanks! Overall, this looks good.

 https://coveralls.io/builds/24017667 shows `confparse.c` coverage as
 97.64%. The uncovered lines seem to be error handling code. Did you have a
 previous Coveralls run on that branch that showed that file at 100%
 coverage?

 I made some minor comments on the pull request.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30893#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs