[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30893 [Core Tor/Tor]: Refactor and improve test coverage in confparse.c

#30893: Refactor and improve test coverage in confparse.c
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  1
Parent ID:  #29211        |         Points:  1
 Reviewer:  catalyst      |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------

Comment (by nickm):

 Replying to [comment:8 nickm]:
 > Ah, I see what the problem was with the coverage.  I wrote those tests
 _after_ I had moved some functions while working on #30864, and then
 backported them.  I'll write a few more tests for that code.

 If it's okay with you, though, I'll also add those tests as part of
 #30864, since otherwise I'm going to run into conflicts with marking these
 functions STATIC.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30893#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs