[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30868 [Circumvention/Snowflake]: Modify client rendezvous library to remove hard-coded responses
#30868: Modify client rendezvous library to remove hard-coded responses
-------------------------------------+----------------------------------
Reporter: cohosh | Owner: (none)
Type: defect | Status: closed
Priority: Medium | Milestone: Tor: unspecified
Component: Circumvention/Snowflake | Version: Tor: unspecified
Severity: Normal | Resolution: not a bug
Keywords: ex-sponsor-19, easy | Actual Points:
Parent ID: #29259 | Points:
Reviewer: | Sponsor: Sponsor28
-------------------------------------+----------------------------------
Comment (by dcf):
Replying to [comment:2 dcf]:
> it looks like [https://gitweb.torproject.org/pluggable-
transports/snowflake.git/tree/client/lib/lib_test.go?id=91255463c68c3ada6adc8718bf380cbd654fe9ef#n297
this test] is checking the for the literal string "No snowflake proxies
currently available." rather than a status code of 503.
No, I was mistaken. The test is just checking the text of the error
message, which is okay. The broker returns an empty body for status 503,
and [https://gitweb.torproject.org/pluggable-
transports/snowflake.git/tree/client/lib/rendezvous.go?id=91255463c68c3ada6adc8718bf380cbd654fe9ef#n113
here] is where the status codes get translated into error strings.
{{{
case http.StatusServiceUnavailable:
return nil, errors.New(BrokerError503)
case http.StatusBadRequest:
return nil, errors.New(BrokerError400)
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30868#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs