[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30644 [Core Tor/Tor]: Add our own base-64 encoded ed25519 public key in dirserv_add_own_fingerprint()
#30644: Add our own base-64 encoded ed25519 public key in
dirserv_add_own_fingerprint()
--------------------------+------------------------------------
Reporter: teor | Owner: neel
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-ed25519 | Actual Points:
Parent ID: #22029 | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------------
Changes (by teor):
* keywords: => tor-ed25519
* status: needs_review => needs_revision
* milestone: Tor: unspecified => Tor: 0.4.2.x-final
Comment:
Thanks for this change!
This code is independent of the rest of #22029, so please make a separate
branch for it.
Then someone else can review that branch in this ticket.
The code needs these changes:
* add_rsa_fingerprint_to_dir() can fail and return -1, if it does,
dirserv_add_own_fingerprint() should return -1
* add_ed25519_to_dir() can fail and return -1, if it does,
dirserv_add_own_fingerprint() should return -1
You can do the check and the warning like this:
https://github.com/torproject/tor/pull/970/commits/f1a236a8360ce0af2ad1bece4e89960463e57e3f
#diff-c535b81e06d7fed27d5d3cdaabf1c4b8R160
But please use a different log message for each warning.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30644#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs