Re: [tor-bugs] #30920 [Core Tor/Tor]: Detect uint64 overflow in config_parse_units()

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#30920: Detect uint64 overflow in config_parse_units()
---------------------------+------------------------------------
 Reporter:  nickm          |          Owner:  (none)
     Type:  defect         |         Status:  new
 Priority:  Low            |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |        Version:
 Severity:  Minor          |     Resolution:
 Keywords:  easy overflow  |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------------------

Comment (by guigom):

 Replying to [comment:4 teor]:
 > Thanks for offering to help out.
 > That code looks good.

 Thank you.

 > We'll also need some unit tests.

 I will be reading
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/WritingTests.md
 first as I need to understand how to properly implement unit test for the
 tor project.

 > Do you use git?
 > We accept pull requests on GitHub, or send us the URL of your git
 repository.

 I'll post the link to the PR once submitted.

 > If you can add a changes file, that would also be helpful:
 >
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md#n95

 Sure!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30920#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs