[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30864 [Core Tor/Tor]: Move variable manipulation code out of confparse.c
#30864: Move variable manipulation code out of confparse.c
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points: 2.5
Parent ID: #29211 | Points: 1
Reviewer: catalyst | Sponsor: Sponsor31-can
--------------------------+------------------------------------
Comment (by nickm):
Here is an overview of the commits in this branch:
> checkSpace.pl: Allow 'bool' before a space and an open-paren
> Start moving types that will be used for config vars to lib/conf
> Move unit-parsing code to src/lib/confmgt
> Add a function to append an existing line to a config line list.
These are preliminary refactoring, code movement, and cleanup commits to
prepare the code for the next commit.
> Add a "typed_var" abstraction to implement lvalue access in C.
This is the most important commit in the patch: it extracts code from
confparse.c and moves it to lib/confmgt.
> Further clarify our clarification about the type of POSINT
> Add unit tests for the unitparse.c module.
These are leftover clarifications and coverage fixes from #30893.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30864#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs