[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10760 [Applications/Tor Browser]: Integrate TorButton to TorBrowser core to prevent users from disabling it

#10760: Integrate TorButton to TorBrowser core to prevent users from disabling it
-------------------------------------------------+-------------------------
 Reporter:  Rezonansowy                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  AffectsTails, tbb-parity, ux-team,   |  Actual Points:
  TorBrowserTeam201906, GeorgKoppen201906        |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:60 acat]:
 > Thanks for the review :)
 >
 > I addressed your comments (and some other small things I found while
 looking at it) in https://github.com/acatarineu/torbutton/commits/10760+1.
 I also squashed the previous 9cf79bcf222cfb1ca47f2cd6f119ac1f19b2f54d,
 ce346d069afa5f1a42dfa13eb8fce2a23cfbf679 and
 4dd346e2b81527785d7f8b68a5cff14972dd645c (overlays removal) into the new
 0140cfca33be68fedd895672ab7e88f55b023803. The other commits are in the
 same place, with some changes addressing the comments.
 >
 > Some of the inconsistencies (but not all) were because initially I had
 more style fixes (all ESLint ones), but I decided to undo most of them
 (and keep the important ones) to reduce the number of changes. I think in
 the process I undid too much (e.g. some of the short-form Services.obs,
 Services.strings, Services.cookies...).

 No worries. The changes in `10760+1` look good to me (with one thing to
 think about):

 d3b70db2205de2a12e6bf6133818b9b005c7f6c9 -- good
 ba1d6f3b0bf32a2a5a1b42466169d348b49b58b4 -- using a NullPrincipal for new
 tabs seems indeed to be a good idea; Would we get away with that for
 `about:tor` as well given that we try hard to give it only content privs
 with the `nsIAboutModule` flags?
 0140cfca33be68fedd895672ab7e88f55b023803 -- okay
 81101babce500fb2e2a6e534f5586afea2f5b247 -- okay
 8ae82f990355f28f32e56cdf4a191b3fdf8a874b -- okay
 cbcb5da551a459e2c4140409be6d03959e18be62 -- okay
 bdbd3ac550bf2efe9e5ae97a656f1f868eff4699 -- okay

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10760#comment:65>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs