[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30934 [Circumvention/Snowflake]: Add a "Turn Off/On" toggle
#30934: Add a "Turn Off/On" toggle
-------------------------------------+--------------------------
Reporter: arlolra | Owner: cohosh
Type: defect | Status: assigned
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: snowflake-webextension | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------+--------------------------
Comment (by cohosh):
I got a start on implementing this here:
https://github.com/cohosh/snowflake/tree/webext-toggle
The first commit is a UI update from antonela.
The
[https://github.com/cohosh/snowflake/commit/e74bf4fd26c9719395210190f03fd3f9c661a5c5
second commit] is a refactoring of the broker poll. To disable snowflake,
we need to somehow break the infinite poll loop that cycles between
`countdown` and `findClients`. I pulled this out into a `setInterval` call
and slightly changed how to determine whether there are available
proxyPairs.
Finally in
[https://github.com/cohosh/snowflake/commit/89fe80d0a1226a533deae5fa5b18b98e7150c936
the third commit], to add the Off/On toggle functionality, we have to
change how the webpage handles this. It doesn't make sense to use cookies
and completely reload the web extension as before, so I added an enabled
variable to the UI class an messaging back and forth to update this.
There's still a few more things to do:
- take a look at the bug in #30998
- change the snowflake image to reflect whether or not it's enabled
- update unit tests
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30934#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs