[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30732 [Applications/Tor Browser]: "Your Firefox is critically out of date" banner

#30732: "Your Firefox is critically out of date" banner
--------------------------------------+-----------------------------------
 Reporter:  hellomebois               |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_information
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+-----------------------------------
Changes (by gk):

 * priority:  Low => Medium
 * cc: mcs, brade (added)


Comment:

 Replying to [comment:10 steph]:
 > I also get this banner. I don't remember ever having modified anything,
 and I don't have any add-ons, but my value for
 datareporting.healthreport.uploadEnabled was true.

 Did you start to see the banner recently or is that already ongoing for a
 while? And does it go away if you flip the pref?

 So, we set the pref to `false` in `000-tor-browser.js`. There is only one
 way this get set to `true` (apart from changing the pref manually) which
 is via https://searchfox.org/mozilla-
 esr60/source/toolkit/components/telemetry/healthreport-prefs.js#10. Which
 is only included if `MOZ_SERVICES_HEALTHREPORT` is defined
 (https://searchfox.org/mozilla-
 esr60/source/modules/libpref/greprefs.js#6). And that seems to be the
 case. So, maybe we have some race-condition here in the pref system that
 is causing this and we should make sure `MOZ_SERVICES_HEALTHREPORT` is not
 defined in the first place? (And `MOZ_TELEMETRY_REPORTING` and
 `MOZ_DATA_REPORTING` and friends) mcs/brade: what do you think?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30732#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs