[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #10760 [Applications/Tor Browser]: Integrate TorButton to TorBrowser core to prevent users from disabling it
#10760: Integrate TorButton to TorBrowser core to prevent users from disabling it
-------------------------------------------------+-------------------------
Reporter: Rezonansowy | Owner: tbb-
| team
Type: defect | Status:
| needs_revision
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: AffectsTails, tbb-parity, ux-team, | Actual Points:
TorBrowserTeam201906, GeorgKoppen201906 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:67 acat]:
> I addressed the comments in a new branch: https://github.com/acatarineu
/tor-browser/compare/30429+1..30429+2.
>
> I rebased the previous branch, fixing up the torbutton commit and
squashing the circuit UI commit. Also realized that I had done the locale
deduplication changes as a fixup for the torbutton integration commit, but
> I think it should have been for the security UI one. So I moved those
changes to the security UI commit (Bug 25658). Also included a couple of
changes not mentioned in the review: removed redundant torbutton in
`toolkit/moz.build` and removed `Example *` from `identityPanel.inc.xul`.
>
> Is it fine to take 30429+2 as the next 'active' branch for #30429, or
will make the ongoing review of the patches more difficult?
Works for me. I stick to `30429` for now until I am done with that one for
a first round.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10760#comment:70>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs