[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30934 [Circumvention/Snowflake]: Add a "Turn Off/On" toggle
#30934: Add a "Turn Off/On" toggle
-------------------------------------+-----------------------------
Reporter: arlolra | Owner: cohosh
Type: defect | Status: merge_ready
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: snowflake-webextension | Actual Points:
Parent ID: | Points:
Reviewer: arlolra | Sponsor:
-------------------------------------+-----------------------------
Changes (by arlolra):
* status: needs_review => merge_ready
Comment:
Looks good to me, just some nits about being consistent with whitespace
(tabs vs spaces, and all that).
> These commits could do with a squashing
Also, please rebase your commits on master before merging so that we don't
have any merge commits.
I made a couple of follow up commits that I'd appreciate you having a look
at in,
https://github.com/keroserene/snowflake/commits/webext-toggle
> I haven't gotten the rotation to work yet with the svg image.
Yeah, some sort of indication that it is active would be nice, like
rotation or switching to green. Is rotation going to be too distracting
in the browserAction icon?
A final note is that this doesn't save the toggle state so a user needs to
turn it on at every browser restart.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30934#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs