[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30979 [Core Tor/Tor]: pre-push hook runs practracker unconditionally

#30979: pre-push hook runs practracker unconditionally
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  git-scripts   |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 Replying to [ticket:30979 nickm]:
 > Our pre-push hook script runs practracker whenever it exists.  But we
 only want to run practracker on branches that are targeted for master.
 >
 > I think perhaps we should change it to try making check-local?  Or
 perhaps it could check for the existence of some other file that we could
 use to indicate whether we want practracker to run.

 Checking another file would be nice: I don't run configure to generate a
 Makefile in my upstream push directories, but I still want practracker to
 run on them.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30979#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs