[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2696 [Tor Relay]: Tor doesn't compile under LLVM/clang with --enable-gcc-warnings

#2696: Tor doesn't compile under LLVM/clang with --enable-gcc-warnings
-----------------------+----------------------------------------------------
 Reporter:  sjmurdoch  |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  minor      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by nickm):

 Ah, I had totally missed that last_seen_in_minutes was a bitfield.  That
 makes sense now.  I'll add a doxygen comment to MAX_LAST_SEEN_IN_MINUTES
 to explain the value.

 time_t is allowed to be negative if it's before 1970.  It generally isn't,
 but it's nice to avoid signed/unsigned comparisons.

 Tor works if int is 64-bit.  At least, Tor is supposed to work if int is
 64-bit.

 Will add that comment and merge.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2696#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs