[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7944 [Flashproxy]: Standalone flash proxy
#7944: Standalone flash proxy
-------------------------+--------------------------------------------------
Reporter: akrey | Owner: dcf
Type: enhancement | Status: needs_revision
Priority: normal | Milestone:
Component: Flashproxy | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Changes (by dcf):
* status: new => needs_revision
Comment:
Replying to [comment:9 arlolra]:
> I rebased cjb's work onto the HEAD of master and got this working. Also
added a package.json file to simplify the npm install and fixed a small
bug in the facilitator. This work can be found on the standalone branch of
my github repo,
>
> https://github.com/arlolra/flashproxy/tree/standalone
Thank you for doing this. For reference below I'm talking about
https://github.com/arlolra/flashproxy/commit/3c08ad9c9ea506dfaf158d41128fefa5d6bca39e.
Do you think you could rebase your changes into logical commits? For
example, each bug fix should be its own commit, and the addition of
`package.json` needs to be its own commit. Each commit needs to have an
informative log message.
Please undo any non-functional changes, like at
https://github.com/arlolra/flashproxy/commit/3c08ad9c9ea506dfaf158d41128fefa5d6bca39e#L1L806
where it's hard to tell if you only changed whitespace or if there is
something different in the code.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7944#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs