Re: [tor-bugs] #8206 [Tor]: Check return values from fcntl and setsockopt

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#8206: Check return values from fcntl and setsockopt
----------------------------+-----------------------------------------------
 Reporter:  nickm           |          Owner:                    
     Type:  defect          |         Status:  needs_revision    
 Priority:  minor           |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor             |        Version:                    
 Keywords:  tor-relay easy  |         Parent:                    
   Points:                  |   Actualpoints:                    
----------------------------+-----------------------------------------------
Changes (by asn):

  * status:  needs_review => needs_revision


Comment:

 Looks good. Two nitpicks:

 In `_evdns_nameserver_add_impl()` there is an `int flags` definition that
 seems unused.

 Can you use `tor_close_socket()` in `tor_open_socket()` instead of the
 `#if closesocket() #else close()` block?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8206#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs