[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15086 [Tor Browser]: tor circuit display has text positioning/alignment problems for RTL languages

#15086: tor circuit display has text positioning/alignment problems for RTL
languages
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  arthuredelstein        |     Status:  needs_revision
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-circuit-display, tbb-usability,
  Browser                |  TorBrowserTeam201503R, GeorgKoppen201503R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Looks good. I'd like to get two nits fixed:

 1)
 {{{
 // Updates the Tor circuit display SVG, showing the current domain
 }}}
 It is no SVG anymore as far as I can see.

 2) I agree that this bug fixes #13074 as well. If you have that fix in the
 same commit (which is fine for me) please give a hint in the commit
 message as well. This makes it a lot easier for people doing the release
 to get the changelog right (they can then just look for bug numbers with
 |git log|)

 I tested a while the ar version and it behaves weird. (See attachment) Not
 sure if that is something we can/should fix, though. I guess there is an
 RTL/LTR mixup causing this due to yet untranslated strings?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15086#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs