[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6411 [Tor]: Adding hidden services through control socket

#6411: Adding hidden services through control socket
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  yawning
  kevinevans             |     Status:  needs_revision
         Type:           |  Milestone:  Tor: 0.2.7.x-final
  enhancement            |    Version:  Tor: 0.2.3.19-rc
     Priority:  normal   |   Keywords:  hidden-service control maybe-
    Component:  Tor      |  proposal tor-hs globalleaks-wants
   Resolution:           |  Parent ID:  #8993
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by atagar):

 Hi yawning, your spec addition looks great! Delightfully precise, I like.
 :P

 Only thoughts are...

 * Maybe add the following note to the end of ADD_ONION? "Controllers MUST
 tolerate unrecognized keyword arguments."

 * You might want to consider making 'DiscardPK' a keyword argument instead
 ('DiscardPK=1'). That's more common for booleans like this than a
 positional argument.

 Out of curiosity why does DEL_ONION disavow knowledge of hidden services
 not made by this controller connection? I'm guessing there's security
 reasons behind it but not sure offhand what they are.

 Presently the controller has full access over adding/removing hidden
 services. Unless I'm missing something with this change we're explicitly
 making use cases like "Connect to the control port and shut down all
 existing hidden services" impossible.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6411#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs