[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15436 [Tor]: Unaligned access in SipHash24 code

#15436: Unaligned access in SipHash24 code
-------------------------+--------------------------------
     Reporter:  pstumpf  |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:  Tor: 0.2.5.11
   Resolution:           |   Keywords:  crash
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------

Comment (by yawning):

 Replying to [comment:4 cypherpunks]:
 > Converting a pointer to void to a pointer of any object type doesn't
 require explicit casts.

 In C yeah.  I was being consistent with the original code (and the
 upstream), which has the cast, presumably for the benefit of people
 building this with a C++ compiler.

 Anyway, the submitter replied to the bug tracker e-mail confirming the
 branch works as advertised.  If nickm cares about the cast, he can either
 tell me to change it, or change it when merging.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15436#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs