[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7255 [Tor Browser]: Prompt if Tor Browser is Maximized

#7255: Prompt if Tor Browser is Maximized
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  gk
  mikeperry              |     Status:  assigned
         Type:  defect   |  Milestone:
     Priority:  major    |    Version:
    Component:  Tor      |   Keywords:  tbb-fingerprinting-resolution, tbb-
  Browser                |  usability, tbb-bounty, tbb-torbutton,
   Resolution:           |  tbb-4.5-alpha
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by gk):

 * owner:  tbb-team => gk
 * status:  new => assigned


Comment:

 Okay, I tried to implement a blocking modal dialog popping up after the
 user clicked on the maximize button, but before the resizing is happening,
 in order to stop it if needed from extension land. That is not working
 very well. Then I looked at the native code in order to do that in C++
 directly but that is quite involved due to platform-dependent behavior. I
 decided not to mess with that as I don't want to risk the stability for
 the alpha/stable that is coming.

 Thus, I will work on a patch that is already using resizing related code
 in torbutton giving users a non-blocking choice (meaning the resizing is
 not blocked by the notification). I am inclined to use a doorhanger
 notification as the modal dialog does not make sense if we are not
 blocking the resizing either IMO but am open to other ideas.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7255#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs