[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16248 [Tor]: [Assertion] connection_stop_reading: Assertion conn->read_event failed; aborting

#16248: [Assertion] connection_stop_reading: Assertion conn->read_event failed;
aborting
-------------------------------------------------+-------------------------
 Reporter:  yurivict271                          |          Owner:
     Type:  defect                               |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  027-backport, must-fix-              |        Version:
  before-028-rc                                  |     Resolution:
Parent ID:                                       |  Actual Points:
 Reviewer:                                       |         Points:
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 I would love to have a comment on `connection_check_event` here because by
 reading the patch I can understand that the connection must have a valid
 pointer `event` except for DNS request (???). Would be nice to explain why
 this exception. This comment has been removed with this commit but doesn't
 explain much anyway:

 {{{
 -  /* if dummy conn then no socket and no event, nothing to do here */
 }}}

 Else, lgtm!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16248#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs