[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18447 [Tor]: Possible double-free in test_options.c

#18447: Possible double-free in test_options.c
------------------------------------------+--------------------------------
 Reporter:  stevenc99                     |          Owner:
     Type:  defect                        |         Status:  reopened
 Priority:  Low                           |      Milestone:  Tor:
Component:  Tor                           |  0.2.8.x-final
 Severity:  Normal                        |        Version:
 Keywords:  validate__transproxy FreeBSD  |     Resolution:
Parent ID:                                |  Actual Points:
 Reviewer:                                |         Points:
                                          |        Sponsor:  None
------------------------------------------+--------------------------------
Changes (by stevenc99):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Your commit for #18448 seems good to me, thanks.

 Thanks for this too;  although I don't see it yet in Git master?

 What we also could do here, is assert that a platform-specific
 TransProxyType test did run (in this block which is guarded by
 USE_TRANSPARENT).  That way if some new platform implements
 USE_TRANSPARENT, the test will deliberately fail until a TransProxyType
 test is written for that platform, so it isn't forgotten.  See
 0002-test_options.c-assert-that-TransProxyType-is-tested.patch.  Thanks
 again!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18447#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs