[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20059 [Core Tor/Tor]: Bug: Duplicate call to circuit_mark_for_close

#20059: Bug: Duplicate call to circuit_mark_for_close
--------------------------+------------------------------------
 Reporter:  cypherpunks   |          Owner:  nickm
     Type:  defect        |         Status:  accepted
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * owner:   => nickm
 * status:  needs_information => accepted


Comment:

 Okay; the first close is here in command.c:
 {{{
     /* the destroy came from behind */
     circuit_set_p_circid_chan(TO_OR_CIRCUIT(circ), 0, NULL);
     circuit_mark_for_close(circ, reason|END_CIRC_REASON_FLAG_REMOTE);
 }}}
 And the second is here in onion.c:
 {{{
     log_info(LD_CIRC,
              "Circuit create request is too old; canceling due to
 overload.");
     circuit_mark_for_close(TO_CIRCUIT(circ),
 END_CIRC_REASON_RESOURCELIMIT);
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20059#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs