[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21540 [Core Tor/Tor]: Warning "Failure from drain_fd"



#21540: Warning "Failure from drain_fd"
-------------------------------------------------+-------------------------
 Reporter:  PjotrV                               |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Low                                  |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.9
 Severity:  Minor                                |     Resolution:
 Keywords:  supressed 029-backport 030-backport  |  Actual Points:
Parent ID:                                       |         Points:  2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 This pattern is used except in `recv_ni()` which removes the unneeded
 `else`:

 {{{
 +    if (errno == EINTR)
 +      goto again;
 +    else
 +      return -errno;
 +  }
 }}}

 I would suggest going for the same pattern, one or the other.

 The rest lgtm.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21540#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs