[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25373 [Core Tor/Tor]: Avoid needless wakeups for token bucket refills.

#25373: Avoid needless wakeups for token bucket refills.
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  (none)
     Type:  enhancement   |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #25500        |         Points:
 Reviewer:                |        Sponsor:  Sponsor8
--------------------------+------------------------------------

Comment (by arma):

 I'm a fan.

 In fact, if we're doing just-in-time refilling, we might even be able to
 get more fine-grained than once-every-100-ms. That is, we could look at
 how far through the second we are, and refill proportional to that
 fraction.

 (It is an open question whether we still have strange bumps in our
 bandwidth flows now that we moved to 10-refills per second. We definitely
 had the strange bumps when it was 1-refill-per-second. Also, refill rates
 interact in subtle ways with the scheduler, so it might be good to check
 with pastly/rob/dgoulet to see if they have any guidance here.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25373#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs