[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29706 [Core Tor/Tor]: Test failure due to memory leaks in shared-random unit tests

#29706: Test failure due to memory leaks in shared-random unit tests
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-ci, tor-test, memory-            |  Actual Points:  0.5
  management, 029-backport-partial,              |
  034-backport, 035-backport, 040-backport       |
Parent ID:                                       |         Points:  0.5
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:1 teor]:
 > I have two pull requests on 0.2.9:
 >
 > A minimal version that fixes the unit tests on 0.2.9:
 > https://github.com/torproject/tor/pull/774

 We should merge pr/774 to 0.4.0 and master, then to 0.2.9 and later once
 the CI passes.

 > A refactor that fixes the underlying memory management bug on 0.2.9:
 > https://github.com/torproject/tor/pull/775

 We should not merge pr/775.
 This refactor includes the fix in pr/774.
 It also independently fixes the bug by making the memory management work
 better.
 I don't think we'll backport this refactor to 0.2.9.

 > And a merge of the refactor to 0.3.4:
 > https://github.com/torproject/tor/pull/776
 > (There were some trivial conflicts where I needed to combine two sets of
 changes.)

 We should merge pr/776 to 0.4.0 and master.
 Then we should test it in an alpha, and backport it as far back as we
 think we'll backport any other shared random changes.
 (For authorities, that's 0.3.4 right now. For clients, that's probably
 0.3.5, because it's LTS.)

 I'll open a child ticket for pr/774.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29706#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs