[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29440 [Applications/Tor Browser]: Update about:tor when Tor Browser is updated
#29440: Update about:tor when Tor Browser is updated
-------------------------------------------------+-------------------------
Reporter: antonela | Owner: tbb-
| team
Type: task | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ux-team, tbb-update, | Actual Points:
TorBrowserTeam201903R, tbb-8.5 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by mcs):
Replying to [comment:22 gk]:
> Two final questions (I think :) ):
>
> 1) What's the reason for having
> {{{
> + m_tb_prefs.clearUserPref(kShouldNotifyPref);
> }}}
> in the Torbutton patch? What is the scenario you are worried about here
that makes you clearing the user pref?
We need to clear that pref so that the post-update variation of the
about:tor page is only shown once.
> 2) What is "tor-right" in "include in the tor-right corner" in the
Torbutton commit message? Did you mean "upper-right"? (If so, what about
RTL bundles)
Apparently I have been thinking about "tor" too much. That was supposed to
read "top-right" but in any case you are correct to question it. In an RTL
browser it will be on the left. I fixed the commit message on the
following branch (which contains the same two patches as before):
https://gitweb.torproject.org/user/brade/torbutton.git/log/?h=bug29440-03
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29440#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs