[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29706 [Core Tor/Tor]: Test failure due to memory leaks in shared-random unit tests: long-term fix
#29706: Test failure due to memory leaks in shared-random unit tests: long-term fix
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.2.9.1-alpha
Severity: Normal | Resolution:
Keywords: consider-backport-after-authority- | Actual Points: 1.1
test, consider-backport-after-0404-alpha, |
tor-ci, tor-test, memory-management, 034 |
-backport-maybe, 035-backport, 040-backport |
Parent ID: | Points: 0.5
Reviewer: asn | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: merge_ready => needs_review
* milestone: Tor: 0.3.5.x-final => Tor: 0.4.1.x-final
* actualpoints: 1.0 => 1.1
Comment:
One of the tests failed if we happened to init during the commit-reveal
state transition period:
{{{
shared-random/utils_auth: [forking]
FAIL ../src/test/test_shared_random.c:1173:
assert(sr_state_get_current_srv() OP_EQ NULL): 0000000002DFC350 vs
0000000000000000
[utils_auth FAILED]
}}}
https://ci.appveyor.com/project/torproject/tor/builds/23057542/job/0066lphdf9c9oc3l?fullLog=true#L6552
I added a commit to https://github.com/torproject/tor/pull/776 to always
clear the SRVs after test init, and before setting either SRV in the
tests.
Let's merge to 0.4.0 and master, and try again?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29706#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs