Re: [tor-bugs] #29434 [Core Tor/Tor]: Consider removing linux-tor-prio.sh from contrib/operator-tools

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#29434: Consider removing linux-tor-prio.sh from contrib/operator-tools
-------------------------------------------------+-------------------------
 Reporter:  rl1987                               |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  technical-debt, fast-fix, nickm-     |  Actual Points:  0.1
  merge, asn-merge                               |
Parent ID:                                       |         Points:  0.1
 Reviewer:  juga, teor                           |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => merge_ready
 * points:   => 0.1
 * actualpoints:   => 0.1
 * keywords:   => technical-debt, fast-fix, nickm-merge, asn-merge
 * reviewer:  juga => juga, teor
 * type:  task => enhancement


Comment:

 I have reviewed this pull request, and I think we should remove this
 script.
 (But now I can't merge it, because I have reviewed it.)

 Here is why:

 Replying to [comment:5 juga]:
 > Replying to [comment:2 rl1987]:
 > > I asked [0] and nobody replied. I think it's safe to remove it.
 >
 > i found the link [0]: https://lists.torproject.org/pipermail/tor-
 relays/2019-February/016995.html
 >
 > In a fast search i found that someone was still using it in 2015 [1].

 Our earliest supported release is 0.2.9, which was released in December
 2016:
 https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CoreTorReleases#Current

 So we don't support things that were only used back in 2015.

 And we never fixed a bug in the script, where it confuses kilobits and
 kilobytes:
 https://lists.torproject.org/pipermail/tor-talk/2015-January/036458.html

 So the script has been unmaintained for at least 4 years.

 > Just some questions:
 > Is it possible that some other application/device using Tor is using
 it?.

 If they are, they can keep a copy of the script, and maintain it
 themselves.

 > Any idea on how we could find out easy?.

 Remove the script, document the removal in the release notes, and see if
 someone complains.

 > Do you know if there's some other recommended way to achieve the same
 this script does?.

 BandwidthRate and BandwidthBurst are supported, cross-platform torrc
 options that limit Tor's bandwidth. They are integrated with the bandwidth
 weighting system.

 I would not recommend using this script instead, because large changes in
 relay bandwidth are not a good experience for Tor users. (And they lead to
 inaccurate bandwidth weights on the network.)

 > Should the script itself be removed from too?.

 This pull request removes the script from Tor's future releases.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29434#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs