[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28652 [Core Tor/sbws]: When sbws stops making progress, log a warning
#28652: When sbws stops making progress, log a warning
--------------------------------+-----------------------------------
Reporter: teor | Owner: juga
Type: defect | Status: merge_ready
Priority: Medium | Milestone: sbws: 1.1.x-final
Component: Core Tor/sbws | Version:
Severity: Normal | Resolution:
Keywords: no-changes-version | Actual Points:
Parent ID: #28547 | Points: 1
Reviewer: asn | Sponsor:
--------------------------------+-----------------------------------
Changes (by asn):
* status: needs_review => merge_ready
Comment:
Replying to [comment:9 juga]:
> should be fixed now
Hm, better. And the test looks good.
I think there might be more stuff you can hide into the heartbeat module
so that they are not exposed in the main loop. The goal is to simplify the
main loop and hide the heartbeat details into the heartbeat module.
I did an implementation here:
https://github.com/torproject/sbws/pull/354/commits/944bad5561dc92d04569ed06eceadd139315e0d4
However, I was not able to test it because my user file does not work
anymore (something about country codes?), and I'm not sure how to run the
unittest either.
If you like the code feel free to use it, otherwise, feel free to merge
the current state of your branch. It's all good.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28652#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs