Re: [tor-bugs] #28329 [Applications/Tor Browser]: Design TBA+Orbot configuration UI/UX

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28329: Design TBA+Orbot configuration UI/UX
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, ux-team, TBA-a3,         |  Actual Points:
  TorBrowserTeam201903, tbb-8.5                  |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:78 gk]:
 > Looking over `28329_20` I got some new nits:
 >
 > `all the expected preferences are is` <- s/are is/are/

 TorNetworkPreferenceFragment:disableBridges
 >
 > `// If bridgesLine1 was not null, then append a newline.` <-
 `bridgesLine1` can be `null` and we still can land there with
 `bridgeLine2` being not null (which can happen if a user for some reason
 leaves the first line out but starts to populate the second (and third
 line) instead; so maybe "If bridgesLine1 or bridgesLine2 was not null"

 Yes, I'll move this comment so it is clearer. This comment is specifically
 explaining why we add the `"\n" +` string. Moving it within the if-block
 above the string assignment should help.
 >
 > `Log.i(LOGTAG, "provideBridge is empty. Disabling.");` I feel we should
 only emit his log line or a similar one if we are actually disabling
 bridges, but that's not clear at that point. Thus, please move this line
 to a place where disabling bridges is essentially certainly to happen (and
 maybe do a "provideBridge is" -> "custom bridges are").

 Agreed.

 New branch coming soon.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28329#comment:79>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs