[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29036 [Core Tor/Tor]: Coverage merge failures cause test_process_slow stderr check to fail

#29036: Coverage merge failures cause test_process_slow stderr check to fail
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  ahf
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Major                                |     Resolution:
 Keywords:  teor-merge, 041-accepted-20190115,   |  Actual Points:  0.5
  regression, tor-ci, 029-backport,              |
  034-backport, 035-backport, 040-backport       |
Parent ID:                                       |         Points:  0.5
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 Hi ahf, catalyst,

 Replying to [comment:15 teor]:
 > * change `make reset-gcov` so it deletes ".gcov" files
 >   * so we don't accidentally use stale files if the coverage command
 fails
 >   * it also makes the cache smaller

 I still think we should change reset-gcov delete the .gcov files. They
 aren't any good in the cache, and they will hide some kinds of coverage
 build/execution failures. What do you think?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29036#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs