[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29896 [Core Tor/Tor]: Backport connection_dir_buf_add() to 0.3.4 and later

#29896: Backport connection_dir_buf_add() to 0.3.4 and later
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-dirauth, metrics-needs, tor-     |  Actual Points:  0.1
  bwauth, 035-removed-20180711, 040-roadmap-     |
  proposed, 035-backport, 040-backport           |
Parent ID:  #21377                               |         Points:  0.1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:
     tor-dirauth, metrics-needs, tor-bwauth, 035-removed-20180711, 040
     -roadmap-proposed, 034-backport, 035-backport, 040-backport
     =>
     tor-dirauth, metrics-needs, tor-bwauth, 035-removed-20180711, 040
     -roadmap-proposed, 035-backport, 040-backport
 * status:  assigned => needs_review
 * points:   => 0.1
 * actualpoints:   => 0.1


Comment:

 We won't be backporting to 0.3.4, because #21377 doesn't rebase cleanly to
 0.3.4.

 I cherry-picked the commits for the new function and changes file from
 https://github.com/torproject/tor/pull/696 in #28816. But I didn't take
 the refactoring commit.

 Here are the pull requests:
 * 0.3.5: https://github.com/torproject/tor/pull/854
 * master merge: https://github.com/torproject/tor/pull/855 (testing only)
   * the merge shouldn't change anything, because the commits are already
 in master

 #28816 has already been reviewed by 2 people, and it's been in nightly for
 4 weeks. So I could backport this change as soon as CI has passed.

 But I think we should just cherry-pick the commits on to the branch in
 #29897, before doing the refactor.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29896#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs