[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29853 [Core Tor/sbws]: sbws should show relays for diagnostics, even when MIN_REPORT has not been reached

#29853: sbws should show relays for diagnostics, even when MIN_REPORT has not been
reached
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  juga
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  sbws:
                                                 |  1.1.0
Component:  Core Tor/sbws                        |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-bwauth, sbws-1.0-must-           |  Actual Points:
  moved-20181128, sbws-11x-final-                |
  removed-20190312, sbws-110-proposed, changes-  |
  version-minor                                  |
Parent ID:  #28563                               |         Points:
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by juga):

 Replying to [comment:10 nickm]:
 > I don't understand why the changes here didn't cause/require changes in
 the test files?

 Yeah, sorry, this code is quite confusing, it really needs
 refactor/renaming and better comments.

 So, we have the following cases:
 - case 0: the number of eligible relays is over the 60% of the consensus,
 nothing is set.
 - case 1: after filtering, there are not eligible relays, they will be set
 "vote=0 under_min_report = 1" and they will also have "unmeasured=1 bw=1"
 because they are not eligible.
 - case 2: after scaling, the number of relays is less than 60% in the
 consensus, they will be set "vote=0 under_min_report =1", the won't have
 "unmeasured=1", but some of them may have "bw=1" just because that's the
 bandwdith after scaling

 I added a test to check the 3 cases.

 The changes in this branch, *did* require changes in other tests, in
 concrete:

 - test_torflow_scale:
   i mocked consensus to pretend the network has only 1 relay so that the
 filtered relays are over the 60% and the scaling expected results continue
 working. Nothing regarding under_min_report changes here.

 - test_from_results_read
   i hardcoded `under_min_report` because update_progress would be None and
 `if not min_perc` will set under_min_report

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29853#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs