Re: [tor-bugs] #29662 [Core Tor/Tor]: Introduce assert functions that allow us to printf error message

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#29662: Introduce assert functions that allow us to printf error message
------------------------------------------------+--------------------------
 Reporter:  rl1987                              |          Owner:  rl1987
     Type:  enhancement                         |         Status:
                                                |  needs_revision
 Priority:  Medium                              |      Milestone:  Tor:
                                                |  0.4.1.x-final
Component:  Core Tor/Tor                        |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  asn-merge, nickm-merge, teor-merge  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:  ahf                                 |        Sponsor:
------------------------------------------------+--------------------------

Comment (by rl1987):

 Replying to [comment:10 nickm]:
 > Can the "Non-fatal assertion %s failed" lines be reached with `extra ==
 NULL`?  I think it can, and I think that's a bug.
 >

 That preserves the old code behavior (for no `expr` and variable
 arguments, thus `extra == NULL`) and enables using the same functions for
 `tor_assert{_nonfatal}()` and the new `tor_assertf{_nonfatal}()` macros.
 Unless I'm missing something here?

 > Shouldn't the tor_assertion_failed_ and tor_bug_occurred_ functions have
 CHECK_PRINTF annotations now?
 >

 Fixed in 999137dcd7406812c99f496b231edaaca3fb7155.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29662#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs