Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#33557: Update Android Toolchain for Fenix
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, Android,                 |  Actual Points:
  TorBrowserTeam202003R                          |
Parent ID:  #33184                               |         Points:
 Reviewer:  sysrqb                               |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:7 gk]:
 > Replying to [comment:2 sisbell]:
 > > I've updated to handle toolchain used by fenix (and android-
 components). The standalone toolchain script is no longer supported. The
 following link covers the changes we need to make. On the plus side, the
 tar file will be smaller.
 > >
 > > https://developer.android.com/ndk/guides/other_build_systems
 > >
 > > In the config, I made more param versions configurable, as I expect we
 will need to upgrade frequently as fenix is in rapid development. I also
 added gradle to the path which means we don't need to specify full-path in
 projects.
 > >
 > > The Commit:
 > >
 > > https://github.com/sisbell/tor-browser-build/commits/bug-33557
 >
 > I've not looked closely at how Fenix is built but isn't Mozilla using
 their own `clang` here? As we are doing for Fennec-based builds currently
 as well? If so, then we should bump the clang version to what Mozilla
 uses. And the Rust version, too. I don't see any child bugs for those in
 the list for the parent one and those two components are kind of toolchain
 components, so I figured you might want to deal with them in this ticket.
 :) But child bugs for #33184 would be fine, too, I think...

 From what I can tell working through the build, fenix project itself is
 not doing any rust or native builds.  This is handled by Mozillas
 application-services project and geckoview project

 In regards to application-services, these deal with cloud services which
 we don't want to support.

 https://github.com/mozilla/application-services

 This is project is built by Mozilla and is downloaded by fenix as an aar,
 which native libraries.

 https://maven.mozilla.org/maven2/org/mozilla/appservices/full-
 megazord/0.53.0/full-megazord-0.53.0.aar

 Looking through the components, they are largely related to sync and
 firefox accounts, which I don't believe we want to support. I'm in the
 process of creating patches to remove these projects. I want to see what
 breaks without the application-service components.

 The second part I see for native is is geckoview

 https://searchfox.org/mozilla-central/source/mobile/android

 This downloads as
 https://maven.mozilla.org/maven2/org/mozilla/geckoview/geckoview-
 beta/74.0.20200227210932/geckoview-beta-74.0.20200227210932.aar

 But yes, we do need an issue for this project (I'll open that). And this
 support will likely require some changes to the toolchain.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33557#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs