[tor-bugs] Re: [Tor Bug Tracker & Wiki] #462: Auto Tor Toggle

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#462: Auto Tor Toggle
-----------------------+----------------------------------------------------
 Reporter:  mikeperry  |         Type:  enhancement  
   Status:  new        |     Priority:  major        
Milestone:  1.4        |    Component:  Tor-Torbutton
  Version:  1.1        |   Resolution:  None         
 Keywords:             |  
-----------------------+----------------------------------------------------
Changes (by mikeperry):

  * priority:  minor => major


Old description:

> It has been requested that Torbutton provide the ability to either turn
> tor on for urls with
> a particular prefix (ie tor:// or tors://), or to add the ability to
> specify certain bookmarks
> are Tor-only.
>
> The latter feature seems much more interesting, but I'm not sure if the
> bookmarks engine allows
> you to add on extra fields. Perhaps both features need to be implemented
> in tandem, so users
> can then just bookmark tor:// urls.
>
> The extension possibly should ask for confirmation also. Not sure I like
> the idea of tor state
> sometimes magically toggling on just because a website had an img
> src="tor://" in there or something.
>
> [Automatically added by flyspray2trac: Operating System: All]

New description:

 It has been requested that Torbutton provide the ability to either turn
 tor on for urls with
 a particular prefix (ie tor:// or tors://), or to add the ability to
 specify certain bookmarks
 are Tor-only.

 The latter feature seems much more interesting, but I'm not sure if the
 bookmarks engine allows
 you to add on extra fields. Perhaps both features need to be implemented
 in tandem, so users
 can then just bookmark tor:// urls.

 The extension possibly should ask for confirmation also. Not sure I like
 the idea of tor state
 sometimes magically toggling on just because a website had an img
 src="tor://" in there or something.

 [Automatically added by flyspray2trac: Operating System: All]

--

Comment:

 This is implemented in 'master' branch by koryk, but it needs additional
 testing and bugfixing. In particular, img tags and other browser content
 can cause the toggle to happen. We need some code to ensure that the
 toggle happens only if the toggle url is actually in the browser url bar,
 and it hasn't been a redirect or a refresh.

 KoryK has test cases for this. He should be prodded into attaching them to
 this bug.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/462#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online