[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2129 [Tor Relay]: Allow Tor client functionality even when we hibernate

#2129: Allow Tor client functionality even when we hibernate
-------------------------+--------------------------------------------------
 Reporter:  arma         |          Owner:                    
     Type:  enhancement  |         Status:  needs_revision    
 Priority:  normal       |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Relay    |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------
Changes (by nickm):

  * status:  new => needs_revision
  * milestone:  Tor: unspecified => Tor: 0.2.4.x-final


Comment:

 This sounds like a pretty good idea!

 A couple of quick comments:
   * It looks like you've made a git repository by importing the "HEAD"
 commit of the  Tor repository, rather than by cloning the Tor repository.
 This makes it basically impossible for Git to merge your changes cleanly.
 The right way to use Git here would be to use "git clone" to make a copy
 of the Tor repo, then using "git branch" or "git checkout -b" to make a
 new branch, making your changes to that branch, and pushing that branch to
 your public repo.  If you use that workflow, it becomes very easy for Git
 to find and merge your changes.  Also, that way you won't need to open a
 separate repository for every version of Tor.
   * So you know what to expect, this is probably going to have to wait for
 0.2.4.x (which should open for merges very soon, I hope)!  I am not
 merging new features into 0.2.3.x if I can possibly help it right now.

 Based on review of the 0.2.3.14-alpha branch:

   * It looks like there are some unrelated CBT changes on this branch?
   * Changing connection_is_listener() directly is probably not a good
 idea.  After all, AP_LISTENER connections are still listeners-- this patch
 doesn't make them _not_ be listeners; it just tries to treat them in a
 different way.
   * Sebastian's comment about hibernation and bandwidth probably still
 applies.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2129#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs