[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #3940 [Tor Client]: Allow MapAddress .exit even if AllowDotExit is 0
#3940: Allow MapAddress .exit even if AllowDotExit is 0
------------------------+---------------------------------------------------
Reporter: sjmurdoch | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: Tor: 0.2.3.x-final
Component: Tor Client | Version: Tor: 0.2.2.32
Keywords: regression | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
Changes (by nickm):
* status: needs_revision => needs_review
Comment:
Replying to [comment:12 grarpamp]:
> If SocksPort is the only place where literal strings of
fqdn/ip.<fp>.exit
> names are presented by the user, that is the only place that should
check
> AllowDotExit. Meaning: maybe a bug in manpage re physical IP addresses:
>
> AllowDotExit 0|1
> ... /TransPort/NATDPort ...
>
> I disabled ADE for now, looks like what's in the works is fine too. Thx.
Hmmm. That's a actually a pretty reasonable idea for a fix, maybe. I
can't recall why we did it the other way back in 3e4379c2e73bf4.
Please consider, examine, review, and test branch "bug3940_redux" in my
public repository. I think this time, maybe I got it right? (There are
some more complexities discussed in the commit message that make the patch
nontrivial)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3940#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs