[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #5520 [Vidalia]: Test the new bootstrap procedure in Vidalia alpha
#5520: Test the new bootstrap procedure in Vidalia alpha
---------------------+------------------------------------------------------
Reporter: chiiph | Owner: sebb
Type: task | Status: needs_review
Priority: normal | Milestone: Vidalia: 0.3.x
Component: Vidalia | Version:
Keywords: | Parent:
Points: | Actualpoints:
---------------------+------------------------------------------------------
Changes (by sebb):
* status: new => needs_review
Comment:
https://github.com/sebthestampede/vidalia/commit/2f629bd0c558544285e413a1ff9e084078be1d13
branch: 5520_bootstrap_test
I've reached a point where I can really use a code review, there are few
points that I'm not sure of:
- I'm new to CMake, so it'd be nice if someone more experienced verifies
if the test code is integrated correctly into the project
- there are few places in the main vidalia code I needed to alter in order
to make test code working, I've left comments there
- bootstrap code in vidalia is simplified too, with use of signals / slots
(we talked about it some time ago on irc), it looks like it works
correctly, I'm curious to know your opinion on this implementation
This is not the final version, its more like I need to know if this is
going in good direction, so any hints are welcome.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5520#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs