[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5454 [Stem]: ExitPolicy Class for stem

#5454: ExitPolicy Class for stem
-------------------------+--------------------------------------------------
 Reporter:  gsathya      |          Owner:  atagar        
     Type:  enhancement  |         Status:  needs_revision
 Priority:  normal       |      Milestone:                
Component:  Stem         |        Version:                
 Keywords:               |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------

Comment(by gsathya):

 Replying to [comment:4 atagar]:
 Sorry about the delay, exams are finally over, getting back to stem
 hacking..

 I've ported the ExitPolicy.get_summary() method.

 > I would suggest rebasing your branch onto the current master and squash
 what you have so far...

 Done.

 > > exit_policies = stem.version.ExitPolicy()
 >
 > Copy and paste error. ;)

 Fixed.

 > > elif policy.is_ip_wildcard and self.is_port_wildcard: return False
 >
 > This is just an attribute of the ExitPolicyLine so the
 "self.is_port_wildcard" will cause an error.

 Fixed.

 > > def isExitingAllowed(self):
 >
 > Should follow the underscore convention.

 Fixed.

 > My guess is that we'll want an abstract parent class (ExitPolicyLine)
 and a couple for the implementations (ConsensusExitPolicyLine which is
 what ExitPolicyLine is now and MicrodescriptorExitPolicyLine for
 microdescriptors). But maybe I'm wrong. Please read through the spec
 though and see if something else makes better sense (and better names!).

 According to the microdescriptor spec - "In the first version, the
 microdescriptor should contain the onion-key element, and the family
 element from the router descriptor,  and the exit policy summary as
 currently specified in dir-spec.txt."
 I can't seem to find the exit policy summary spec in dir-spec.txt, Is
 there some place else I should check?

 I'll get started on the unit tests once I figure out how to implement the
 exit policy for microdesriptors.

 Thanks!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5454#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs