Re: [tor-bugs] #5951 [Tor Client]: Don't keep file_handle around on windows for mmap

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#5951: Don't keep file_handle around on windows for mmap
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  minor       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 Patch looks plausible. Suggest 0.2.3 since shondoit says it doesn't help
 him.

 As a minor fix,
 {{{
 -  res->file_handle = CreateFile(tfilename,
 +  file_handle = CreateFile(tfilename,
                                  GENERIC_READ, FILE_SHARE_READ,
                                  ...
 }}}

 will want some reindenting.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5951#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs