[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #5374 [Tor Relay]: getsockname() to check for address change failed
#5374: getsockname() to check for address change failed
-----------------------+----------------------------------------------------
Reporter: funkstar | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: Tor: 0.2.2.x-final
Component: Tor Relay | Version: Tor: 0.2.3.12-alpha
Keywords: | Parent:
Points: | Actualpoints:
-----------------------+----------------------------------------------------
Changes (by nickm):
* status: new => needs_review
* milestone: Tor: 0.2.3.x-final => Tor: 0.2.2.x-final
Comment:
Okay, after investigating a little, I can confirm that we're doing the
wrong thing for XP here too -- it's just that XP behaves wrong in a
different way than windows 8.
It looks like Windows doesn't want you to call getsockname() on a
nonblocking socket on which you have called connect, but which has not yet
finished connecting. On XP, it succeeds, and calls your address
INADDR_ANY. On Windows 8, it appears to fail with this warning.
The right fix, I think, is to delay our call to
client_check_address_changed until the connection has actually completed.
Please see branch "bug5374" in my public repository. This could apply to
0.2.2.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5374#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs